feat: added blur event to having input in query section #5684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
frontend/src/container/QueryBuilder/filters/HavingFilter/HavingFilter.tsx
Outdated
Show resolved
Hide resolved
SagarRajput-7
previously approved these changes
Sep 3, 2024
YounixM
previously approved these changes
Sep 3, 2024
|
@rahulkeswani101 we should only make the chip only if the entered input is complete having clause. For example, if I hover out before selecting any operator it creates this which is invalid.
|
rahulkeswani101
dismissed stale reviews from YounixM and SagarRajput-7
via
a63c36c
SagarRajput-7
approved these changes
Sep 5, 2024
ahmadshaheer
approved these changes
Sep 17, 2024
@srikanthccv Can you Please check this and let me know if any other changes are required as I have fixed this now. |
YounixM
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues / PR's
https:/SigNoz/engineering-pod/issues/1364
Screen.Recording.2024-08-13.at.11.43.58.AM.mov