Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added Messaging queue detail page #5690

Merged
merged 10 commits into from
Aug 29, 2024
Merged

feat: added Messaging queue detail page #5690

merged 10 commits into from
Aug 29, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Aug 14, 2024 •
edited
Loading

Summary

Detail page

  • [Header title and page setup]

    • Title and page setup
    • Reset button and time picker
    • Options - (with other options as coming soon)

  • [Config options] (using auto-complete API )

    • Consumer grp
    • Topic
    • Partitions

  • [Main graph]

    • Time series graph
    • Tooltip
    • shareable link
    • Full screen view

  • [Detail view]

    • Consumer grp
    • Producer details
    • Network latency
    • Redirections

Related Issues / PR's

https:/SigNoz/engineering-pod/issues/1642

Screenshots

Screen.Recording.2024-08-26.at.5.50.34.PM.mov

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the enhancement New feature or request label Aug 14, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 force-pushed the messaging-queue-detail-page branch 2 times, most recently from 2903913 to 9e54b06 Compare August 16, 2024 09:21
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 marked this pull request as ready for review August 26, 2024 12:31
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

vikrantgupta25
vikrantgupta25 previously approved these changes Aug 27, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7
Messaging queue overview (#5782)
fd8367e 
* feat: added messaging queue overview page

* feat: added get-started links

* feat: fixed comments

* feat: messaging queue misc tasks (#5785)

* feat: added lightMode styles

* feat: misc fix

* feat: misc fix

* feat: added customer tooltip info text

* feat: removed reset btn until the funcitonality is clear

* feat: fixed comments
vikrantgupta25
vikrantgupta25 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM
Copy link
Member

YounixM commented Aug 29, 2024

@SagarRajput-7 : Please check the failed checks

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7
Copy link
Contributor Author

@SagarRajput-7 : Please check the failed checks

commitlint / lint-commits is failing due to the sub-PRs merged into this one, it shouldn't be an issue

@SagarRajput-7 SagarRajput-7 merged commit 140533b into develop Aug 29, 2024
10 of 15 checks passed
@SagarRajput-7 SagarRajput-7 deleted the messaging-queue-detail-page branch August 29, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@ahmadshaheer ahmadshaheer ahmadshaheer approved these changes

@vikrantgupta25 vikrantgupta25 vikrantgupta25 approved these changes

@rahulkeswani101 rahulkeswani101 rahulkeswani101 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SagarRajput-7 @YounixM @ahmadshaheer @vikrantgupta25 @rahulkeswani101