Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added onDragSelect to DBCall and External metric app #5694

Merged
merged 5 commits into from
Aug 20, 2024
Merged

fix: added onDragSelect to DBCall and External metric app #5694

merged 5 commits into from
Aug 20, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Aug 14, 2024 •
edited
Loading

Summary

Related Issues / PR's

https:/SigNoz/engineering-pod/issues/1670

Screenshots

Screen.Recording.2024-08-14.at.8.17.46.PM.mov

Affected Areas and Manually Tested Areas

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Aug 14, 2024
vikrantgupta25
vikrantgupta25 previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CLAassistant
Copy link

CLAassistant commented Aug 16, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SagarRajput-7
Copy link
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.✅ SagarRajput-7✅ makeavish❌ Sagar Rajput

Sagar Rajput seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Had some messed up local config, but contract is signed from my main account

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 merged commit 7cff073 into develop Aug 20, 2024
12 checks passed
@srikanthccv srikanthccv deleted the SIG-1670 branch September 12, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@makeavish makeavish makeavish approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

@vikrantgupta25 vikrantgupta25 vikrantgupta25 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SagarRajput-7 @CLAassistant @YounixM @makeavish @srikanthccv @vikrantgupta25