fix: nan and inf values in formula result #5733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
nityanandagohain
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes https:/SigNoz/engineering-pod/issues/1687
The formula result can be +/-Inf when the denominator value is zero. It can be Nan if one of the values involved in expression is Nan. Even if we send them back to the client, it doesn't know what to do with these values. For example, in time series it incorrectly shows them as random numbers. In tables, it's not desirable for end users to see Nan or +Inf. The same reasons apply to other panel types. The best thing to do for now is to skip them from the result. I will let the real-world use cases come when it's required to include these in the result.