Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for changing the font size in logs #5739

Merged
merged 7 commits into from
Aug 22, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Aug 21, 2024

Summary

this PR adds the support to change the font size to small / medium / large in the logs explorer pages

Design :- https:/SigNoz/engineering-pod/issues/1205#issuecomment-1953604809

Small : font size - 11px; line height - 16px; padding - 1px;
Medium : font size - 13px; line height - 20px; padding - 1px;
Large : font size - 14px; line height - 24px; padding 2px;

Related Issues / PR's

fixes - https:/SigNoz/engineering-pod/issues/1205

contributes to - #5169

Screenshots

Screen.Recording.2024-08-22.at.12.19.44.AM.mov

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the enhancement New feature or request label Aug 21, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@GeekBoySupreme
Copy link
Collaborator

@vikrantgupta25 can we decrease the padding/spacing between the lines by 2-4px when the font is small? Looks like a lot of space there rn.

@vikrantgupta25
Copy link
Collaborator Author

can we decrease the padding/spacing between the lines by 2-4px when the font is small? Looks like a lot of space there rn.

done @GeekBoySupreme

@GeekBoySupreme
Copy link
Collaborator

Looks good.

@ankitnayan
Copy link
Collaborator

default to small?

@vikrantgupta25
Copy link
Collaborator Author

default to small?

this will only be for the first time user opens the page, after that whatever the user selects will be stored as a preference and used subsequently, Kept the default medium so that once this is deployed users shouldn't feel a sudden jerk of reduced size.

can change it to small if you think otherwise. cc @ankitnayan

@ankitnayan
Copy link
Collaborator

I want to keep small as default since many users have asked to reduce size already. I want to see this in staging though before confirmation. If video is good enough proxy, I am okay with small size

@vikrantgupta25
Copy link
Collaborator Author

I want to keep small as default since many users have asked to reduce size already. I want to see this in staging though before confirmation. If video is good enough proxy, I am okay with small size

okay , reduced the default to small rather than medium ✅

@YounixM
Copy link
Member

YounixM commented Aug 22, 2024

@vikrantgupta25 : We need to centralize the decisions related to styles we have taken for this change.

let's collate all the style changes for small / medium / large as PR comment so that we have documentation for the same whenever want to loop back to this.

@vikrantgupta25 vikrantgupta25 merged commit 96b8181 into develop Aug 22, 2024
12 of 13 checks passed
@srikanthccv srikanthccv deleted the change-font-size branch September 12, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants