chore: add total count and state filter #5745
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@ahmadshaheer highlighted few things to be addressed
currentAvgResolutionTime
orpastAvgResolutionTime
in invalid change them to 0state
filter in the timeline APItotal
count of rows in the timeline APIThe first three changes are simple and need minimal change. The links to related logs and traces are the same as the ones we have here so there is no major logic change but minor changes that don't apply to alers. I created a todo item for myself to combine them the
signoz/pkg/query-service/rules/threshold_rule.go
Lines 552 to 744 in 072693d