Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change returned error from list to error #5805

Merged
merged 6 commits into from
Aug 30, 2024
Merged

Conversation

srikanthccv
Copy link
Member

Summary

The returned type is unnecessarily complicated. It is updated to just return the error. When there is more than one error from the validation step, they are combined and returned as one.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Aug 29, 2024
@srikanthccv srikanthccv changed the title chore: remove old data migrations chore: change returned error from list to error Aug 29, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Base automatically changed from strict-types to develop August 30, 2024 05:04
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cleaner now 👍

@srikanthccv srikanthccv merged commit 16738ea into develop Aug 30, 2024
12 checks passed
@srikanthccv srikanthccv deleted the err-cleanup branch August 30, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants