Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make the raw view the default view for logs #5816

Merged
merged 6 commits into from
Sep 2, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Aug 31, 2024

Summary

  • make the raw view as the default view for logs explorer page.

  • skipping one assertion for now as there is some formatting issue with jest dom. will fix this later. not blocking the PR for now.

Related Issues / PR's

contributes to - #4115

Screenshots

NA

Affected Areas and Manually Tested Areas

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Aug 31, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

SagarRajput-7
SagarRajput-7 previously approved these changes Aug 31, 2024
@ankitnayan
Copy link
Collaborator

what about those who have already set Column view as their default? They should still see Column view when they open the logs explorer page

@vikrantgupta25
Copy link
Collaborator Author

what about those who have already set Column view as their default? They should still see Column view when they open the logs explorer page

yes this is just the default for whoever hasn't set it already in the local storage. No existing set preferences will be affected. @ankitnayan

@vikrantgupta25 vikrantgupta25 merged commit 6f7999a into develop Sep 2, 2024
12 of 13 checks passed
@vikrantgupta25 vikrantgupta25 deleted the default-logs-view branch September 2, 2024 06:18
ahmadshaheer pushed a commit that referenced this pull request Sep 4, 2024
* chore: make the raw view the default view for logs

* fix: jest test cases

* fix: jest test cases

* chore: fix one test case

* fix: formatting issue

* fix: formatting issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants