Issue with initial dashboard title value in rename modal fixed #5821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…selected dashboard
SagarRajput-7
approved these changes
Oct 7, 2024
YounixM
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we go back and forth between multiple dashboard views, it was observed that the initial title value in the rename modal was being set to an outdated value, i.e. the title of a previously visited dashboard. This was due to the context not being updated before the first render of the dashboard component, which resulted in an incorrect initial value being set.
Related Issues / PR's
Fixes #5780
Affected Areas and Manually Tested Areas
Dashboard component affected.