Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: apply resource filters on coming from service details to traces page #5827

Merged
merged 5 commits into from
Sep 10, 2024
Merged

feat: apply resource filters on coming from service details to traces page #5827

merged 5 commits into from
Sep 10, 2024

Conversation

ahmadshaheer
Copy link
Collaborator

@ahmadshaheer ahmadshaheer commented Sep 2, 2024 •
edited
Loading

Summary

Actions in the serviceDetail view that take to the trace explorer page should have the resource attributes applied by default. Eg, selected host.name should translate to host.name = 0201ca93c5ae in the trace explorer page

Related Issues / PR's

close #2865

Screenshots

NA

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the enhancement New feature or request label Sep 2, 2024
@ankitnayan
Copy link
Collaborator

#2865 (comment)

@ahmadshaheer ahmadshaheer changed the title feat: apply resource fitlers to traces page feat: apply resource filters to traces page Sep 3, 2024
@ahmadshaheer ahmadshaheer force-pushed the feat/apply-resource-filters-to-traces-pge branch from c52595d to b96b444 Compare September 5, 2024 18:36
@ahmadshaheer ahmadshaheer changed the title feat: apply resource filters to traces page feat: apply resource filters on coming from service details to traces page Sep 5, 2024
@ankitnayan
Copy link
Collaborator

@ahmadshaheer please record a video of environment and host.name being propagated to trace explorer page from the serviceList -> serviceDetail page. I am not able to see it work

@ahmadshaheer
Copy link
Collaborator Author

@ahmadshaheer please record a video of environment and host.name being propagated to trace explorer page from the serviceList -> serviceDetail page. I am not able to see it work

Sure. https://signoz-team.slack.com/archives/C02TJ466H8U/p1725890834952129

@ankitnayan ankitnayan mentioned this pull request Sep 10, 2024
Merged
srikanthccv
srikanthccv approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test the functionality myself. Approving to unblock merge.

@ankitnayan
Copy link
Collaborator

ankitnayan commented Sep 10, 2024 •
edited
Loading

#5827 (comment)

@ahmadshaheer please create an issue for this and merge this PR by fixing the build and resolving conv

@ankitnayan ankitnayan self-requested a review September 10, 2024 09:31
@ahmadshaheer
Copy link
Collaborator Author

#5827 (comment)

@ahmadshaheer please create an issue for this and merge this PR by fixing the build and resolving conv

Sure, @ankitnayan.

#5913

@ahmadshaheer ahmadshaheer merged commit 47d42e6 into develop Sep 10, 2024
11 of 12 checks passed
@YounixM YounixM deleted the feat/apply-resource-filters-to-traces-pge branch September 10, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@ankitnayan ankitnayan ankitnayan approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

@SagarRajput-7 SagarRajput-7 SagarRajput-7 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply resource filters to traces page
5 participants
@ahmadshaheer @ankitnayan @YounixM @srikanthccv @SagarRajput-7