Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: alert state change and overall status #5845

Merged
merged 10 commits into from
Sep 9, 2024
Merged

chore: alert state change and overall status #5845

merged 10 commits into from
Sep 9, 2024

Conversation

srikanthccv
Copy link
Member

Summary

This PR

  • changes the table name to _v0 to be explicit in the version
  • removes the random use of "firing" and "normal" string values in code to type from the model
  • fix the issue with overall status where there are no entries or last entry doesn't have it's corresponding complement state, for example, the alert is firing but doesn't have resolved state yet so we need to add the "firing" entry at last

Some of the code is the same as the threshold rule and prom rule. I plan to address this separately.

@github-actions github-actions bot added the chore label Sep 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv srikanthccv marked this pull request as ready for review September 4, 2024 07:06
nityanandagohain
nityanandagohain previously approved these changes Sep 4, 2024
View reviewed changes
pkg/query-service/app/clickhouseReader/reader.go Outdated Show resolved Hide resolved
nityanandagohain
nityanandagohain reviewed Sep 9, 2024
View reviewed changes
pkg/query-service/model/v3/v3.go Outdated Show resolved Hide resolved
pkg/query-service/rules/prom_rule.go Show resolved Hide resolved
pkg/query-service/rules/prom_rule.go Outdated Show resolved Hide resolved
@srikanthccv srikanthccv merged commit 3e32dab into develop Sep 9, 2024
11 of 12 checks passed
@srikanthccv srikanthccv deleted the alert-history-state-change branch September 9, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nityanandagohain nityanandagohain nityanandagohain approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srikanthccv @nityanandagohain