Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add enrichment in threshold rule #5925

Merged
merged 15 commits into from
Sep 17, 2024
Merged

chore: add enrichment in threshold rule #5925

merged 15 commits into from
Sep 17, 2024

Conversation

srikanthccv
Copy link
Member

Summary

Fixes https:/SigNoz/engineering-pod/issues/1757

This change adds the attribute enrichment to two places

  1. prior to preparing the query: this will make sure the query prepared has the relevant metadata to correct results.
  2. while preparing links: this will ensure the explorer link generated has the right attribute metadata.

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Sep 11, 2024
@srikanthccv srikanthccv mentioned this pull request Sep 11, 2024
Merged
Base automatically changed from traces-enrich to develop September 13, 2024 11:13
@srikanthccv srikanthccv marked this pull request as ready for review September 14, 2024 05:36
@srikanthccv srikanthccv merged commit 49dd5f2 into develop Sep 17, 2024
13 checks passed
@srikanthccv srikanthccv deleted the enrich-in-links branch September 17, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nityanandagohain nityanandagohain nityanandagohain approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srikanthccv @nityanandagohain