Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the jest-playwright-test unused package causing axios vulnerability #5972

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Sep 14, 2024

Summary

  • we do not use jest-playwright-test package and it has already been deprecated in support for official playwright/test package which we use for our end to end testing repo as well.
  • and we no longer run any playwright test cases inside our main repo so no concerns with removing this.

Related Issues / PR's

fixes https:/SigNoz/signoz/security/dependabot/149

Screenshots

NA

Affected Areas and Manually Tested Areas

@vikrantgupta25 vikrantgupta25 changed the title chore: remove the jest-playwright-test unused package causing axios v… chore: remove the jest-playwright-test unused package causing axios vunlerability Sep 14, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Sep 14, 2024
@vikrantgupta25 vikrantgupta25 changed the title chore: remove the jest-playwright-test unused package causing axios vunlerability chore: remove the jest-playwright-test unused package causing axios vulnerability Sep 14, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

2 similar comments
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review September 14, 2024 07:57
@YounixM YounixM merged commit fe0d2a9 into develop Sep 16, 2024
13 checks passed
@YounixM YounixM deleted the fix-axios-dependency branch September 16, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants