Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added custom breakdown of one day to handle billing graph issue. #5994

Merged
merged 8 commits into from
Oct 1, 2024

Conversation

rahulkeswani101
Copy link
Contributor

@rahulkeswani101 rahulkeswani101 commented Sep 17, 2024

Summary

Related Issues / PR's

1287

Screenshots

Before -

image

After -

image

Affected Areas and Manually Tested Areas

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Sep 17, 2024
SagarRajput-7
SagarRajput-7 previously approved these changes Sep 24, 2024
@SagarRajput-7
Copy link
Contributor

Please add images also for better understanding

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srikanthccv
Copy link
Member

@rahulkeswani101 can you pass dummy data and share what does it look like if the data exists for 2 days and 3days?

@rahulkeswani101
Copy link
Contributor Author

@rahulkeswani101 can you pass dummy data and share what does it look like if the data exists for 2 days and 3days?

@srikanthccv I am adding the screenshots for you to look at. Please let me know if we are good with this and can merge the PR.

image

image

Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YounixM YounixM merged commit 5ba9c9d into develop Oct 1, 2024
13 checks passed
@srikanthccv srikanthccv deleted the SIG-1287 branch October 1, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants