Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for case insensitive for contains and like queries #6045

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

nityanandagohain
Copy link
Member

@nityanandagohain nityanandagohain commented Sep 20, 2024

This PR adds case insensitive support to like/ilike/contains/ncontains

Attributes

  • We are taking the tradeoff that contains/ncontains/like/ilike won't use the index.

Resources

  • As of now we have two index for resources one is lowecase and the other one is uppercase.
  • Since we want case insensitivity for like/ilike/contains/ncontains , we are using the lowercase index.

For body and resource we are making sure case insensitive search works by using like with lower(column).

For #5555

@github-actions github-actions bot added the enhancement New feature or request label Sep 20, 2024
srikanthccv
srikanthccv previously approved these changes Sep 20, 2024
@nityanandagohain
Copy link
Member Author

Have made a small change with respect to index filter to build it with lowercase which was missed, please have a look at the last commit.

@nityanandagohain nityanandagohain merged commit 3866f89 into develop Sep 23, 2024
13 checks passed
@nityanandagohain nityanandagohain deleted the feat/case-insensitive branch September 23, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants