fix: added support for body contains X tag on pressing enter after selecting attribute key
#6059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
YounixM
previously approved these changes
Sep 24, 2024
SagarRajput-7
previously approved these changes
Sep 25, 2024
nityanandagohain
requested changes
Sep 25, 2024
vikrantgupta25
dismissed stale reviews from SagarRajput-7 and YounixM
via
b1fa91e
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
SagarRajput-7
approved these changes
Sep 25, 2024
nityanandagohain
approved these changes
Sep 25, 2024
YounixM
approved these changes
Sep 25, 2024
raj-k-singh
pushed a commit
that referenced
this pull request
Sep 26, 2024
…selecting attribute key (#6059) * fix: added empty operator in the top to support body contains * fix: address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
body contains Xtag on pressing enter after selecting attribute keybody contains xtags quicklybody containsquicklyRelated Issues / PR's
fixes https:/SigNoz/engineering-pod/issues/1817
Screenshots
Screen.Recording.2024-09-24.at.6.40.52.PM.mov
Affected Areas and Manually Tested Areas