Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed incorrect label for orderBy clause when selected #6177

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Oct 14, 2024

Summary

Related Issues / PR's

#5663
https:/SigNoz/engineering-pod/issues/1689

Screenshots

Before:

Screen.Recording.2024-10-14.at.9.33.23.AM.mov

After:

Screen.Recording.2024-10-14.at.9.30.09.AM.mov

Affected Areas and Manually Tested Areas

Tested:

  • Metric, logs and traces orderBy clause

Important

Fixes incorrect label for orderBy clause in query builder by considering entityVersion in transformToOrderByStringValues.

  • Behavior:
    • Fixes incorrect label for orderBy clause in transformToOrderByStringValues in utils.ts by considering entityVersion.
    • Updates selectedValue computation in useOrderByFilter.ts to use the corrected transformToOrderByStringValues function.
  • Functions:
    • transformToOrderByStringValues now takes entityVersion as an optional parameter to determine label format.
    • Affects cases where columnName is SIGNOZ_VALUE and entityVersion is 'v4'.

This description was created by Ellipsis for 3b0fcfb. It will automatically update as commits are pushed.

@github-actions github-actions bot added the bug Something isn't working label Oct 14, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 marked this pull request as ready for review October 14, 2024 04:22
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3b0fcfb in 24 seconds

More details
  • Looked at 39 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_z9soHlus8W41LhbO


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@SagarRajput-7 SagarRajput-7 merged commit dd09782 into develop Oct 14, 2024
12 of 13 checks passed
@SagarRajput-7 SagarRajput-7 deleted the SIG-5663 branch October 14, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants