Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update default feature flag and error response for formula #6184

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Oct 14, 2024

Summary

Part of #5469


Important

Update default anomaly provider and feature flag for anomaly detection in queryrange.go and plans.go.

  • Behavior:
    • In queryrange.go, added a default case for anomaly provider selection to use NewDailyProvider.
    • In plans.go, changed EnterprisePlan to set AnomalyDetection feature Active to false.
  • Error Handling:
    • In queryrange.go, added a condition to check if a query is a formula by comparing query.QueryName and query.Expression.

This description was created by Ellipsis for 3a89c37. It will automatically update as commits are pushed.

@github-actions github-actions bot added chore enhancement New feature or request labels Oct 14, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3a89c37 in 9 seconds

More details
  • Looked at 45 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. ee/query-service/model/plans.go:376
  • Draft comment:
    Verify if setting AnomalyDetection to false in EnterprisePlan is intentional and aligns with the intended feature set.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the feature flag for AnomalyDetection from true to false in the EnterprisePlan might be intentional, but it should be verified if this aligns with the intended feature set for the Enterprise plan.
2. ee/query-service/model/plans.go:376
  • Draft comment:
    The change from Active: true to Active: false for basemodel.AnomalyDetection in the EnterprisePlan is consistent with the PR's intention to update default feature flags.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the EnterprisePlan feature set is relevant to the PR description.

Workflow ID: wflow_nqxEOm0AX2ffgXVS


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@srikanthccv srikanthccv merged commit bf4c792 into develop Oct 14, 2024
14 checks passed
@srikanthccv srikanthccv deleted the anomaly-ff branch October 14, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants