Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validation check for verification details #103

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Update validation check for verification details #103

merged 4 commits into from
Jun 18, 2024

Conversation

deep-quality-dev
Copy link
Contributor

@deep-quality-dev deep-quality-dev commented Jun 14, 2024 •
edited
Loading

Changelog:

  • Consistent validation check between InitGenesis and AddVerficationDetails.
  • Check if user has valid verifications filtering by type, expiration timestamp, expected issuers.

@MikkySnow
Copy link
Collaborator

Tests from make test-all fails:

# swisstronik/x/evm/keeper_test [swisstronik/x/evm/keeper.test]
x/evm/keeper/sgxvm_connector_test.go:372:126: not enough arguments in call to connector.EVMKeeper.ComplianceKeeper.HasVerificationOfType
        have ("github.com/cosmos/cosmos-sdk/types".Context, "github.com/cosmos/cosmos-sdk/types".AccAddress, "swisstronik/x/compliance/types".VerificationType, nil)
        want ("github.com/cosmos/cosmos-sdk/types".Context, "github.com/cosmos/cosmos-sdk/types".Address, "swisstronik/x/compliance/types".VerificationType, uint32, []"github.com/cosmos/cosmos-sdk/types".Address)
x/evm/keeper/sgxvm_connector_test.go:376:125: not enough arguments in call to connector.EVMKeeper.ComplianceKeeper.HasVerificationOfType
        have ("github.com/cosmos/cosmos-sdk/types".Context, "github.com/cosmos/cosmos-sdk/types".AccAddress, "swisstronik/x/compliance/types".VerificationType, []"github.com/cosmos/cosmos-sdk/types".Address)
        want ("github.com/cosmos/cosmos-sdk/types".Context, "github.com/cosmos/cosmos-sdk/types".Address, "swisstronik/x/compliance/types".VerificationType, uint32, []"github.com/cosmos/cosmos-sdk/types".Address)
x/evm/keeper/sgxvm_connector_test.go:380:125: not enough arguments in call to connector.EVMKeeper.ComplianceKeeper.HasVerificationOfType
        have ("github.com/cosmos/cosmos-sdk/types".Context, "github.com/cosmos/cosmos-sdk/types".AccAddress, "swisstronik/x/compliance/types".VerificationType, []"github.com/cosmos/cosmos-sdk/types".Address)
        want ("github.com/cosmos/cosmos-sdk/types".Context, "github.com/cosmos/cosmos-sdk/types".Address, "swisstronik/x/compliance/types".VerificationType, uint32, []"github.com/cosmos/cosmos-sdk/types".Address) 
        ```

@MikkySnow MikkySnow merged commit 07574fc into develop Jun 18, 2024
@deep-quality-dev deep-quality-dev deleted the fix/genesis-timestamp-validation branch June 18, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delneg delneg delneg left review comments

@MikkySnow MikkySnow MikkySnow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deep-quality-dev @MikkySnow @delneg