cache rule name with error message for reporters to use as they need

[wojciechczerniak]

Just like ESLint and sass-lint expose rule name with error message cache. Not every reporter need to use it but will be useful to display it in editor like ESLint do. Possible future use: find automatic fix by rule name and apply it inline (alt+enter inspections in Webstorm IDE).

BTW. What's the difference between state and cache objects? Some warning message properties are on state (severity) and some are on cache (lineNo, msg, etc). Did I choose the right one?

[SimenB]

What's the difference between state and cache objects?

I don't know actually, they seem to overlap somewhat.

I think we either should make the distinction clear (state being stuff regarding current file, and cache being overall state regarding the whole run), or just merge them together. @rossPatton thoughts? Both are breaking changes, but if you agree, we could do some more breakage, like finally finishing off #161.
I also think it would be nice to only call the reporter after all files are processed, instead of after each single file, at least as an option.

@wojciechczerniak WRT this change, huge 👍 A test would be nice here, though.

And I'm really looking forward to the plugin! 😄

[rossPatton]

i'm cool with merging them, or really with whatever you guys want to do. everything kind of just grew organically, so i'm sure there's tons of room for improvement.

[SimenB]

Cool, made #269 to list any other potential breakage we might want.

@wojciechczerniak A test here, then I'm happy with this PR at least 😄

[wojciechczerniak]

I'm not sure if commit triggered notification so just letting you know about added test.

BTW. JetBrains plugin is released now: stylint-plugin

[SimenB]

LGTM. Unsure why the build is failing now, though... Rebase on master?

I'll test out the plugin asap! Really cool that you made it

[wojciechczerniak]

My test fails on node v4 and below in getFiles.js. I'll investigate.

[wojciechczerniak]

No problem here. Rebase was the right way to go, thanks.

[SimenB]

@wojciechczerniak now it failed only on node 4... Something weird is going on

[wojciechczerniak]

My mistake was to change node version only. I've reproduced Travis step by step. Deleting node_modules each time and npm install && npm test caused the glob() in getFiles.js to throw exception.

With node_modules from v.5 tests are green (?).

When node version is changed the npm changes too. In v5 modules are "flat", in lower versions glob module has it's own node_modules.

[SimenB]

run npm dedupe on install then? Seems buggy though...

[wojciechczerniak]

It's weird. But probably not for us to fix. We deal with async call here which is messed up by configuration change. IMO this exposed problem with this.config writes which I address in #272