Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rootDir option in tsconfig #48

Closed
wants to merge 1 commit into from
Closed

Add support for rootDir option in tsconfig #48

wants to merge 1 commit into from

Conversation

richtea
Copy link

@richtea richtea commented Dec 7, 2015

When the tsconfig.json file specifies a rootDir, this should also affect the generated id of the modules.

Currently, if you have a source file called src/index.ts and your tsconfig is in the root directory, the generated module id will be myname/src/index. This is appropriate if your output file is called dist/src/index.js; but if you have used the rootDir: 'src' option in the tsconfig then you probably want your generated module id to be myname/index.

@kitsonk
Copy link
Contributor

kitsonk commented Dec 11, 2015

@richtea we require CLAs for any contributions as part of the Dojo Foundation. I was unable to find a CLA based on your GitHub username. Could you please take a moment to file a CLA or let me know what username or e-mail address you used?

@richtea
Copy link
Author

richtea commented Dec 11, 2015

Hi

I've completed the CLA under this email address. Please let me know if there is anything else you need from me.

Thanks
Rich

On 11 Dec 2015, at 18:43, Kitson Kelly [email protected] wrote:

@richtea we require CLAs for any contributions as part of the Dojo Foundation. I was unable to find a CLA based on your GitHub username. Could you please take a moment to file a CLA or let me know what username or e-mail address you used?


Reply to this email directly or view it on GitHub.

@richtea
Copy link
Author

richtea commented Dec 14, 2015

Apologies, the CLA is filed under rich -at- tebb.me.uk

@kitsonk
Copy link
Contributor

kitsonk commented Dec 24, 2015

Rich Tebb submitted a CLA on 2015-12-11 21:10:07.

@kitsonk kitsonk closed this in 34491c2 Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants