forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stratum v2 Template Provider common functionality #49
Open
Sjors
wants to merge
16
commits into
2024/06/sv2_connection
Choose a base branch
from
2024/07/sv2-tp-common
base: 2024/06/sv2_connection
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2024
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
August 8, 2024 16:13
3cf779b
to
b549fd6
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
2 times, most recently
from
August 13, 2024 13:48
6894e23
to
fc6ac1e
Compare
Updated to the latest interface changes proposed in bitcoin#30409 and #53. |
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
August 13, 2024 17:14
b549fd6
to
22d033c
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
2 times, most recently
from
August 13, 2024 18:07
491755c
to
16d2381
Compare
Sjors
force-pushed
the
2024/06/sv2_connection
branch
3 times, most recently
from
August 29, 2024 11:49
4f957ee
to
b69544c
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
2 times, most recently
from
August 29, 2024 11:59
ca73422
to
4fa25e0
Compare
Rebased for CMake |
One test still seems brittle:
|
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
September 5, 2024 12:57
b69544c
to
1ca68d2
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
from
September 5, 2024 15:56
1f720ff
to
1912743
Compare
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
September 10, 2024 14:54
1ca68d2
to
b578e0a
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
2 times, most recently
from
September 11, 2024 05:39
598f08a
to
436dc4d
Compare
Moved |
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
from
September 11, 2024 06:37
436dc4d
to
46fa8f1
Compare
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
September 19, 2024 15:02
b578e0a
to
489c9fb
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
2 times, most recently
from
September 19, 2024 16:13
7db898e
to
765af74
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
from
September 20, 2024 06:57
a6e3768
to
7693440
Compare
Sjors
force-pushed
the
2024/06/sv2_connection
branch
2 times, most recently
from
September 20, 2024 09:27
a55fa83
to
5c28af1
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
from
September 20, 2024 09:29
7693440
to
37d2f05
Compare
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
September 20, 2024 16:24
5c28af1
to
53f852b
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
from
September 20, 2024 17:03
37d2f05
to
28bbdc9
Compare
Sjors
force-pushed
the
2024/06/sv2_connection
branch
2 times, most recently
from
October 4, 2024 14:03
d0ae2f6
to
60bb609
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
from
October 4, 2024 14:04
28bbdc9
to
3779b1e
Compare
Rebased after bitcoin#30409 and changes to #50. |
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
October 4, 2024 15:54
60bb609
to
476161f
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
from
October 4, 2024 15:55
3779b1e
to
94f55ad
Compare
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
October 4, 2024 18:13
476161f
to
96f953f
Compare
The template provider will listen for a Job Declarator client. It can establish a connection and detect various protocol errors. Co-Authored-By: Christopher Coverdale <[email protected]> Co-Authored-By: Fi3
Co-authored-by: Christopher Coverdale <[email protected]>
The Mining interface uses this function in the next commit to calculate the coinbase merkle path. Stratum v2 uses this to send a compact work template. This partially undoes the change in 4defdfa, but is not a revert, because the implementation changed in the meantime. This commit also documents the function.
Co-authored-by: Vasil Dimov <[email protected]>
This doesn't solve the underlying problem.
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
from
October 4, 2024 18:15
94f55ad
to
6ac456e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent PR bitcoin#29432. Moved from bitcoin#30475.
Based on:
And the following interface changes:
This contains all Template Provider functionality that can be used by both bitcoin#29432 and the IPC based sidecar alternative #48.