-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the error message of HTTP 404 #205
Comments
However, I think it is not really good if we show an uncertain error message for version error. Do we have any versioning on our api now? By path or by headers (e.g Accept?) If former case, I think we can assume if we call /v2.2/abc it return 404 just say "404 API version not found or endpoint not found" If later case, we should be able to determine version not compatible by adding some details in API response (Or we don't have api versioning at all?) |
Yes. In path. The original problem is that the controller is too old that it does not have api versioning but the skycli has. Actually it is not a problem we will see in the wild because the controller should always be latest. |
Most likely the HTTP 404 is caused by incompatible versions between the client and the controller. We should print a message saying
The text was updated successfully, but these errors were encountered: