Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect BlobStorageService type in the blob storage source. #76

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

s-vitaliy
Copy link
Contributor

@s-vitaliy s-vitaliy commented Jul 9, 2024

Resolves #69

Scope

Implemented:

  • Pass IBlobStorageListService as an argument for the blob storage service constructor instead of IBlobStorageService

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@s-vitaliy s-vitaliy requested a review from a team as a code owner July 9, 2024 14:00
Copy link

github-actions bot commented Jul 9, 2024

Coverage after merging fix-incorrect-interface-type into main will be

80.47%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/Providers/Hosting
   HostBuilderExtensions.cs84.75%58.33%100%90.48%190–192, 227–229
src/Sinks
   SchemaBoundSink.cs100%100%100%100%
   SchemaFreeSink.cs100%100%100%100%
src/Sinks/Extensions
   SchemaFreeSourceExtensions.cs100%100%100%100%
src/Sinks/Json
   JsonSink.cs74.66%42.86%100%77.68%102–105, 149–151, 151, 151, 151, 151, 151, 154–156, 158–159, 161–162, 164, 166, 177, 177–180, 82, 82, 82, 82, 84–86, 96–99
   MultilineJsonSink.cs79.12%52%100%81.69%113, 113, 113, 113, 115–117, 127–130, 133–136, 206–208, 208, 208, 208, 208, 208, 211–213, 215–216, 218–219, 221, 223, 234, 234–238
src/Sinks/Parquet
   ParquetOperations.cs74.68%66.67%87.50%77.45%100–102, 102, 102, 102, 102, 105–107, 159–161, 61–62, 62, 62–65, 65, 65–67, 69, 71–72, 89, 89, 89, 92–96, 96, 96, 98–99
   ParquetSink.cs83.26%64.10%100%85.88%113, 113, 113, 113, 115–117, 133–136, 160, 211–214, 251–253, 253, 253, 253, 253, 253, 256–258, 260–261, 263–264, 266, 268, 279, 279, 285–287, 44
src/Sinks/Parquet/Models
   DataCell.cs100%100%100%100%
src/Sources
   SchemaBoundSource.cs45.45%100%33.33%53.85%27, 31, 35, 40, 43, 52
   SchemaFreeSource.cs86.67%100%83.33%88.89%29
src/Sources/BlobStorage
   BlobStorageSource.cs69.41%33.33%83.33%70.15%101, 101, 103–104, 122–125, 129–130, 130, 130, 133–134, 136–137, 139, 56–62
src/Sources/CdmChangeFeedSource
   CdmChangeFeedSource.cs87.78%77.08%95.45%89.21%159, 161, 190, 194–197, 202–203, 228–231, 258, 282–285, 307–310, 340, 367, 367, 369, 371, 82–88
src/Sources/CdmChangeFeedSource/Extensions
   CsvOperations.cs98.91%97.22%100%100%54
   JsonDocumentOperations.cs100%100%100%100%
   SimpleCdmAttributeExtensions.cs94.12%91.67%100%94.59%27–28, 41
src/Sources/CdmChangeFeedSource/Models
   SimpleCdmAttribute.cs55.24%16.67%84.62%63.24%108, 123–124, 124, 124–126, 129, 129, 129–131, 134, 134, 134–136, 139, 139, 139–141, 144, 144, 144, 144, 144, 144, 144, 144, 144, 144, 144–150, 153–156, 91, 96
   SimpleCdmEntity.cs80%64.29%88.89%82.69%101–103, 106, 106, 112–114, 86–88, 96–98
src/Sources/Extensions
   GraphStageLogicExtensions.cs100%100%100%100%
   SchemaFreeSourceExtensions.cs100%100%100%100%
   SinkExtensions.cs100%100%100%100%
   SourceExtensions.cs100%100%100%100%
   SqlServerUtils.cs100%100%100%100%
src/Sources/RestApi
   RestApiSource.cs73.44%54%82.35%78.16%132, 136–142, 348, 353, 353, 353, 353, 353, 353, 355–358, 373–376, 395, 395–397, 397, 397, 400–401, 403–404, 407, 460–462, 470, 480–481, 483, 485, 487, 487, 487, 487, 487, 487, 487, 487, 487, 493, 497–498, 83–88
src/Sources/RestApi/Extensions
   RestApiExtensions.cs100%100%100%100%
   StringExtensions.cs0%0%0%0%21–26, 26, 26–29, 32–33
src/Sources/RestApi/Models
   PageResolverConfiguration.cs50%100%50%50%27, 33
   RestApiTemplatedField.cs100%100%100%100%
src/Sources/RestApi/Services
   RestApiTemplate.cs75.81%66.67%100%75%100–102, 62–64, 67–69, 73–77, 99
src/Sources/RestApi/Services/AuthenticatedMessageProviders
   DynamicBearerAuthenticatedMessageProvider.cs52.07%38.89%75%56.79%101–103, 108–110, 110, 110, 110, 110, 110, 110–115, 117, 137, 137, 137, 137, 137, 143, 143, 143–144, 147, 147–150, 77–92, 92, 92–95, 95, 95–96
   FixedHeaderAuthenticatedMessageProvider.cs100%100%100%100%
src/Sources/RestApi/Services/PageResolvers
   PageCountingResolver.cs80.49%75%100%81.48%37, 40–41, 43, 52, 59–61
   PageNextTokenResolver.cs65.52%50%100%66.67%30, 37–38, 41, 41, 41–45
   PageOffsetResolver.cs73.68%60%100%76.92%33, 47, 51, 51, 51–54, 57–58
src/Sources/RestApi/Services/PageResolvers/Base
   PageResolverBase.cs100%100%100%100%
src/Sources/RestApi/Services/UriProviders
   PagedUriProvider.cs67.16%50%83.33%72.83%102–104, 106, 113–116, 126, 126, 126, 132–133, 135, 149, 157, 157, 163, 163, 163–165, 168–171, 173–174, 50, 52, 67, 67, 67, 77, 77, 77, 84–86, 88, 95, 95, 95
   SimpleUriProvider.cs60%50%66.67%64.15%100, 102, 104, 34–35, 44, 57–59, 62, 66, 70, 73, 73, 73, 80–82, 84, 88, 90–91, 91, 91, 91, 91, 94–96, 98–99
src/Sources/SqlServer
   FastParquetSchemaValidator.cs87.50%75%100%88.24%34–36
   SqlServerChangeTrackingSource.cs81.39%65.22%92%83.04%100–103, 197, 197,

@s-vitaliy s-vitaliy merged commit 6c53f27 into main Jul 9, 2024
1 check passed
@s-vitaliy s-vitaliy deleted the fix-incorrect-interface-type branch July 9, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement generic blob storage source in Arcane.Framework
2 participants