Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SampleLazy bug #131

Closed
jam40jeff opened this issue Feb 6, 2018 · 2 comments
Closed

Fix SampleLazy bug #131

jam40jeff opened this issue Feb 6, 2018 · 2 comments
Assignees
@jam40jeff
Labels
bug

Comments

@jam40jeff
Copy link
Contributor

SampleLazy computes its value as part of the "last" phase of a transaction. However, if the value constructed contains more FRP objects to add to the graph, this can cause a problem, as those objects will not have their prioritized actions run since the "last" phase is after the "prioritized loop". The fix for this is to make a new "sample" phase which runs after all prioritized actions, but is still part of the "prioritized loop" so that it may add further actions to the prioritized queue to be run.
@jam40jeff jam40jeff self-assigned this Feb 6, 2018
@jam40jeff jam40jeff added the bug label Feb 6, 2018
@jam40jeff
Copy link
Contributor Author

jam40jeff commented Feb 6, 2018 •
edited
Loading

Fixed by the following commits:

73cbcf9
c1b2aa0
523c276
5a3504f

@the-real-blackh
Copy link

I've replaced this bug with ones for individual languages: #124 #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jam40jeff jam40jeff

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@the-real-blackh @jam40jeff