Fix inverted logic for --no-shuffle #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This revision fixes an apparent inverted logic bug in processing of the "--no-shuffle" option. The [text](https://freecontent.manning.com/wp-content/uploads/functional-reactive-programming-in-search-of-the-mythical-von-neumann-machine.pdf) describes the `linked-list` program timing with/without the option as: ``` time ./linked-list --no-shuffle user 0m3.390s time ./linked-list user 1m19.563s ``` However we saw the behavior as inverse, e.g.: ``` $ time ./linked-list --no-shuffle real 1m24.075s user 1m24.054s sys 0m0.020s $ time ./linked-list real 0m3.724s user 0m3.708s sys 0m0.017s ``` Prior to this fix, including the "--no-shuffle" option would make the program shuffle list entries, which was the opposite of the intended effect. This revision also adds an include for the string header as needed for `strcmp` to work correctly in GCC. This was tested with GCC 7.5.0 on Ubuntu 18.04.6 LTS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revision fixes an apparent inverted logic bug in processing of the "--no-shuffle" option.
The text describes the
linked-listprogram timing with/without the option as:However we saw the behavior as inverse, e.g.:
Prior to this fix, including the "--no-shuffle" option would make the program shuffle list entries, which was the opposite of the intended effect.
This revision also adds an include for the string header as needed for
strcmpto work correctly in GCC. This was tested with GCC 7.5.0 on Ubuntu 18.04.6 LTS.