Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FP S1848 (constructor-for-side-effects): Make exception for AWS CDK resources #4357

Closed
ilia-kebets-sonarsource opened this issue Nov 3, 2023 · 0 comments · Fixed by #4554
Closed

Fix FP S1848 (constructor-for-side-effects): Make exception for AWS CDK resources #4357

ilia-kebets-sonarsource opened this issue Nov 3, 2023 · 0 comments · Fixed by #4554
Assignees
@yassin-kammoun-sonarsource
Labels
mmf-2934 https://sonarsource.atlassian.net/browse/MMF-2934
Milestone
10.12

Comments

@ilia-kebets-sonarsource
Copy link
Contributor

Many classes from aws-cdk-lib perform object creation when calling constructors, therefore they have side effects. Since we support actively the AWS lib with custom rules, we should make an exception for such constructors.

This issue was raised in this community ticket: https://community.sonarsource.com/t/s1848-cdk-new-object-reported-as-useless-code-false-positive/103016
@ilia-kebets-sonarsource ilia-kebets-sonarsource added the mmf-2934 https://sonarsource.atlassian.net/browse/MMF-2934 label Jan 25, 2024
Merged
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource added this to the 10.12 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource

Labels
mmf-2934 https://sonarsource.atlassian.net/browse/MMF-2934
Projects
None yet
Milestone
10.12
3 participants
@yassin-kammoun-sonarsource @ilia-kebets-sonarsource @ericmorand-sonarsource