Load package.json on init-linter
#4363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/jsts/src/dependencies/package-json/project-package-json.ts
Outdated
Show resolved
Hide resolved
packages/jsts/tests/analysis/fixtures/package-json/rule-package-json/package.json
Outdated
Show resolved
Hide resolved
packages/jsts/tests/analysis/fixtures/package-json/rule-package-json/rules.js
Outdated
Show resolved
Hide resolved
packages/jsts/src/dependencies/package-json/project-package-json.ts
Outdated
Show resolved
Hide resolved
packages/jsts/src/dependencies/package-json/project-package-json.ts
Outdated
Show resolved
Hide resolved
packages/jsts/src/dependencies/package-json/project-package-json.ts
Outdated
Show resolved
Hide resolved
packages/jsts/src/dependencies/package-json/project-package-json.ts
Outdated
Show resolved
Hide resolved
packages/jsts/src/dependencies/package-json/project-package-json.ts
Outdated
Show resolved
Hide resolved
…on.ts Co-authored-by: Yassin Kammoun <[email protected]>
…on.ts Co-authored-by: Yassin Kammoun <[email protected]>
Co-authored-by: Yassin Kammoun <[email protected]>
Co-authored-by: Yassin Kammoun <[email protected]>
Co-authored-by: Yassin Kammoun <[email protected]>
Co-authored-by: Yassin Kammoun <[email protected]>
make baseDir mandatory
always ignore .scannerwork folder
hashicorp-vault-sonar-prod
bot
assigned yassin-kammoun-sonarsource and unassigned saberduck
hashicorp-vault-sonar-prod
bot
assigned yassin-kammoun-sonarsource and unassigned yassin-kammoun-sonarsource
yassin-kammoun-sonarsource
approved these changes
Nov 10, 2023
hashicorp-vault-sonar-prod
bot
assigned vdiez and unassigned yassin-kammoun-sonarsource
saberduck
reviewed
Nov 10, 2023
| } | ||
|
|
||
| async walkDirectory(dir: string, ignoredPatterns: Minimatch[]) { | ||
| const files = await fs.readdir(dir, { withFileTypes: true }); |
There was a problem hiding this comment.
why do you need to await the result here, if function is async?
There was a problem hiding this comment.
because otherwise files is a promise and would not be able to iterate
saberduck
reviewed
Nov 10, 2023
| continue; // is ignored pattern | ||
| } | ||
| if (file.isDirectory()) { | ||
| await this.walkDirectory(filename, ignoredPatterns); |
There was a problem hiding this comment.
not needed but to keep order of execution
saberduck
reviewed
Nov 10, 2023
| protected List<String> getExcludedPaths() { | ||
| var configuration = this.context.config(); | ||
| var excludedPatterns = Arrays.asList(JavaScriptPlugin.EXCLUSIONS_DEFAULT_VALUE); | ||
| var jsExcludedPatterns = configuration.get(JavaScriptPlugin.JS_EXCLUSIONS_KEY).isPresent() |
There was a problem hiding this comment.
you don't need to do this, if you call getStringArray it will return [] if the property is not defined
saberduck
reviewed
Nov 10, 2023
|
|
||
| protected List<String> getExcludedPaths() { | ||
| var configuration = this.context.config(); | ||
| var excludedPatterns = Arrays.asList(JavaScriptPlugin.EXCLUSIONS_DEFAULT_VALUE); |
There was a problem hiding this comment.
we don't need this variable
saberduck
reviewed
Nov 10, 2023
| @@ -126,4 +132,18 @@ protected boolean shouldAnalyzeWithProgram(List<InputFile> inputFiles) { | |||
| LOG.debug("Will use AnalysisWithProgram"); | |||
| return true; | |||
| } | |||
|
|
|||
| protected List<String> getExcludedPaths() { | |||
There was a problem hiding this comment.
we should share this logic with PathAssesor, by creating utility class with static function, otherwise we will forget to keep the two places in sync
There was a problem hiding this comment.
I wanted to do this, but had doubts about the how-to
|
94.4% Coverage on New Code
0.0% Duplication on New Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.