Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify S1874: Merge with react/no-deprecated #4371

Merged
merged 19 commits into from
Nov 15, 2023
Merged

Modify S1874: Merge with react/no-deprecated #4371

merged 19 commits into from
Nov 15, 2023

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Nov 13, 2023

Fixes #3658


const sonarId = path.basename(__dirname);

describe(`Rule ${sonarId}`, () => {
searchPackageJsonFiles(__dirname, []);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion, but we could call in the beforeAll hook and then clear the database in the afterAll hook.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we can do that... comment base will then clear before each noncompliant, right? and we can use same DB for all

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, you mean beforeAll and not beforeEach, sorry yes you're right

also, just checked and indeed it just creates one test, not multiple, so beforeEach would also work

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vdiez vdiez enabled auto-merge (squash) November 15, 2023 13:57
Copy link

@vdiez vdiez merged commit dc94357 into master Nov 15, 2023
14 checks passed
@vdiez vdiez deleted the new-S1874 branch November 15, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend S1874 with react/no-deprecated: Disallow usage of deprecated methods
2 participants