Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Node.js 14 #4447

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Drop support for Node.js 14 #4447

merged 5 commits into from
Nov 30, 2023

Conversation

saberduck
Copy link
Contributor

@saberduck saberduck commented Nov 30, 2023 •
edited
Loading

Fixes #4445 #4440

yassin-kammoun-sonarsource
yassin-kammoun-sonarsource reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how important this is, but there is also a pom.xml file to update:

SonarJS/sonar-plugin/sonar-javascript-plugin/pom.xml

Lines 313 to 315 in 96387c2

<Implementation-Version>${project.version}</Implementation-Version>
<!-- Keep in sync with NodeDeprecationWarning#MIN_SUPPORTED_NODE_VERSION -->
<NodeJs-Min-Version>14.17.0</NodeJs-Min-Version>

yassin-kammoun-sonarsource
yassin-kammoun-sonarsource approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I also forgot to mention to update:

https:/SonarSource/SonarJS/blob/master/sonar-plugin/sonar-javascript-plugin/src/main/resources/static/documentation.md

Looks good to me otherwise 👍

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@saberduck saberduck enabled auto-merge (squash) November 30, 2023 16:09
@saberduck saberduck merged commit aea5200 into master Nov 30, 2023
14 checks passed
@saberduck saberduck deleted the i4445 branch November 30, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource yassin-kammoun-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Node.js v14
2 participants
@saberduck @yassin-kammoun-sonarsource