-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more analysis warnings #4455
Conversation
...gin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/JavaScriptPlugin.java
Outdated
Show resolved
Hide resolved
...r-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/AnalysisProcessor.java
Outdated
Show resolved
Hide resolved
...javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/AnalysisWithProgram.java
Outdated
Show resolved
Hide resolved
...javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/AnalysisWithProgram.java
Outdated
Show resolved
Hide resolved
...cript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/AnalysisWithWatchProgram.java
Outdated
Show resolved
Hide resolved
…lugins/javascript/JavaScriptPlugin.java Co-authored-by: Ilia Kebets <[email protected]>
...onar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/JsTsSensorTest.java
Outdated
Show resolved
Hide resolved
…lugins/javascript/bridge/AnalysisProcessor.java Co-authored-by: Ilia Kebets <[email protected]>
…lugins/javascript/bridge/AnalysisWithProgram.java Co-authored-by: Ilia Kebets <[email protected]>
…lugins/javascript/bridge/AnalysisWithWatchProgram.java Co-authored-by: Ilia Kebets <[email protected]>
@@ -61,6 +61,7 @@ | |||
|
|||
public class JavaScriptPlugin implements Plugin { | |||
|
|||
public static final String TYPESCRIPT_VERSION = "5.3.2"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add the test we discussed yesterday? the one that reads the package.json file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that the test in src/test/java/com/sonar/javascript/it/plugin/EslintCustomRulesTest.java was implicitly doing so, as the output that it checks comes from node. Do you still think it makes sense to do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it does. If we remove that test, it would be nice to make sure that this assertion is verified.
…lugins/javascript/bridge/AnalysisWithProgram.java Co-authored-by: Ilia Kebets <[email protected]>
…to analysis-warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Fixes #4438
Added warnings on program creation failure and a summary of parsing errors