Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow minimatch to match hidden folders #4502

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Allow minimatch to match hidden folders #4502

merged 2 commits into from
Jan 17, 2024

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Jan 17, 2024

Fixes #4490

yassin-kammoun-sonarsource
yassin-kammoun-sonarsource reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be tricky to write a unit test for this?

@vdiez
cover hidden paths with unit test
f36dbfe 
remove debugging leftovers
@vdiez
Copy link
Contributor Author

vdiez commented Jan 17, 2024

changed the unit test to cover hidden paths. I tested it without the dot: true and it failed to ignore the pattern indeed.

yassin-kammoun-sonarsource
yassin-kammoun-sonarsource approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing, probably due to prettier.

@vdiez
Copy link
Contributor Author

vdiez commented Jan 17, 2024

it's a 404 on npm ci, I guess I'll retry later

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@vdiez vdiez merged commit 529d08d into master Jan 17, 2024
19 checks passed
@vdiez vdiez deleted the fix-packagejson-lookup branch January 17, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource yassin-kammoun-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analysis failing because of resources hoard when node_modules/ is present with lots of dependencies
2 participants
@vdiez @yassin-kammoun-sonarsource