Resolve JS-150 #4680
Merged
Resolve JS-150 #4680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zglicz
approved these changes
May 6, 2024
packages/jsts/src/rules/S107/rule.ts
Outdated
| @@ -137,7 +134,7 @@ export const rule: RuleModule<Options> = { | |||
|
|
|||
| function checkFunction(node: estree.Node) { | |||
| const functionLike = node as unknown as TSESTree.FunctionLike; | |||
| const maxParams = (context.options as Options)[0].maximumFunctionParameters; | |||
| const maxParams = (context.options as Options)[0].max; | |||
| @@ -25,7 +25,7 @@ const MAX_PARAMS_3 = 3; | |||
| const MAX_PARAMS_5 = 5; | |||
|
|
|||
| const createOptions = (maximumFunctionParameters: number): Options => { | |||
There was a problem hiding this comment.
perhaps remove the name "maximumFunctionParameters" throughout the rules codebase?
|
I'll do another release, so maybe could you base your version on plugin v1.0.2? |
ericmorand-sonarsource
force-pushed
the
JS-150
branch
from
4541b9f
to
3a28732
Compare
ericmorand-sonarsource
force-pushed
the
JS-150
branch
from
3a28732
to
54367ad
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JS-150