JS-188 Directive can be used as a Statement #4742
Conversation
quentin-jaquier-sonarsource
force-pushed
the
qj/JS-188
branch
from
09650e4
to
6e3518d
Compare
| @@ -104,7 +104,7 @@ public record ClassExpression(Location loc, Optional<Identifier> id, Optional<Ex | |||
| public record ConditionalExpression(Location loc, Expression test, Expression alternate, Expression consequent) implements Expression {} | |||
| public record ContinueStatement(Location loc, Optional<Identifier> label) implements Statement {} | |||
| public record DebuggerStatement(Location loc) implements Statement {} | |||
| public record Directive(Location loc, Literal expression, String directive) implements DirectiveOrModuleDeclarationOrStatement {} | |||
There was a problem hiding this comment.
Should we rename the top interface ModuleDeclarationOrStatement since Directive is a child of Statement?
There was a problem hiding this comment.
This interface was introduced as the type of Program is:
export interface Program extends BaseNode {
// ...
body: Array<Directive | Statement | ModuleDeclaration>;
}
On one hand, we might want to match this definition, on the other, you are right that it is redundant. No strong feeling on this one, do you think that it is worth it?
There was a problem hiding this comment.
Indeed, I'm not quite sure. How will it be used on the Sonar-Armor side?
There was a problem hiding this comment.
As discussed, let's keep it as it is, and come back at it if there is a need.
quentin-jaquier-sonarsource
force-pushed
the
qj/JS-188
branch
from
6e3518d
to
abd9498
Compare
|
hashicorp-vault-sonar-prod
bot
assigned quentin-jaquier-sonarsource and unassigned ilia-kebets-sonarsource
No description provided.