Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARARMOR-98 SonarArmor JS/TS rules should be in Sonar Way profile #4764

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

quentin-jaquier-sonarsource
Copy link
Contributor

@quentin-jaquier-sonarsource quentin-jaquier-sonarsource commented Aug 14, 2024

This PR only makes sense with https:/SonarSource/sonar-armor/pull/176, and should be merged first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I have one question regarding tests.

@quentin-jaquier-sonarsource quentin-jaquier-sonarsource merged commit 9f1d927 into master Aug 15, 2024
20 of 21 checks passed
@quentin-jaquier-sonarsource quentin-jaquier-sonarsource deleted the qj/SONARARMOR-98 branch August 15, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants