Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release eslint-plugin-sonarjs version 2.0.0 with tag latest #4773

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Aug 22, 2024

No description provided.

Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@vdiez vdiez merged commit 32fb6e8 into master Aug 22, 2024
18 of 19 checks passed
@vdiez vdiez deleted the release-latest branch August 22, 2024 12:43
@karlhorky
Copy link

karlhorky commented Aug 22, 2024

Is there a changelog / release notes for this anywhere?

I can't see any mention of this in:

  1. The GitHub Releases (which seem outdated)
  2. The repository search

The closest thing that I can find is a generated npm package diff like this one from Renovate, but since so many things moved, it seems unreadable

cc @yassin-kammoun-sonarsource

@karlhorky
Copy link

karlhorky commented Aug 22, 2024

@vdiez
Copy link
Contributor Author

vdiez commented Aug 22, 2024

Hi @karlhorky,

there are no specific release notes for the eslint plugin. This new 2.0.0 version was announced in the previous repository, which will be archived in the coming weeks.

We'll think about a proper way to have release notes properly generated.

The main change is that it does now contain all rules from SonarJS instead of a subset. If you have questions about specific rules let us know. We are not accessing network in any of the rules, but we are using the net module from Node.js to parse IPs. As for filesystem, we search for parent package.json files to know if a project has certain dependencies.

Cheers

@karlhorky
Copy link

karlhorky commented Aug 22, 2024

Nice, thanks for the first introduction to 2.0.0 and explanation of the permissions! Looking forward to the full release notes when they are available.

If you're looking for a release notes / changelog solution, many in the Node.js ecosystem have adopted Changesets - maybe also a nice thing for eslint-plugin-sonarjs

This new 2.0.0 version was announced in the previous repository, which will be archived in the coming weeks.

Oh ok, I assume the announcement was the readme change here? Or was there something else too?

@vdiez
Copy link
Contributor Author

vdiez commented Aug 22, 2024

Nothing else, some small announcement in the Sonar Community Roundup, but that's it.

Thanks for the hint on changesets, we'll have a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants