JS-280 Support unknown nodes in AST protobuf file #4786
Conversation
vdiez
requested review from
ericmorand-sonarsource
and removed request for
ilia-kebets-sonarsource
hashicorp-vault-sonar-prod
bot
assigned ericmorand-sonarsource and unassigned ilia-kebets-sonarsource
hashicorp-vault-sonar-prod
bot
assigned ilia-kebets-sonarsource and unassigned ericmorand-sonarsource
| @@ -467,3 +469,7 @@ message FunctionExpression { | |||
| optional bool generator = 4; | |||
| optional bool async = 5; | |||
| } | |||
|
|
|||
| message UnknownNode { | |||
| string astNodeType = 1; | |||
There was a problem hiding this comment.
WDYT?
| string astNodeType = 1; | |
| string rawType = 1; |
There was a problem hiding this comment.
if you accept this change, you will have to adapt the other estree.proto files
There was a problem hiding this comment.
btw, why so many repeated proto files? I think one should be source of truth
There was a problem hiding this comment.
they are repeated because we didn't want to create coupling between the different modules. If we can find a better solution, it would be nice. See https://sonarsource.atlassian.net/browse/JS-197
There was a problem hiding this comment.
As discussed, we will remove the deprecated scripts in tools/estree and only keep a script similar to copy-to-lib.js, named copy-to-plugin.js that copies the original in the bridge to the copy in the plugin.
We should also adapt the header comments in the protofile to identify:
- which one is the original
- which one the copy
- by what script they are maintained in sync
sonar-plugin/bridge/src/test/java/org/sonar/plugins/javascript/bridge/ESTreeFactoryTest.java
Outdated
Show resolved
Hide resolved
sonar-plugin/bridge/src/test/java/org/sonar/plugins/javascript/bridge/ESTreeFactoryTest.java
Outdated
Show resolved
Hide resolved
|
hashicorp-vault-sonar-prod
bot
assigned ilia-kebets-sonarsource and unassigned ilia-kebets-sonarsource
Fixes https://sonarsource.atlassian.net/browse/JS-280