Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove estree.proto file duplication #4787

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Aug 29, 2024

Fixes #

# Conflicts:
#	sonar-plugin/bridge/src/main/protobuf/estree.proto
#	tools/estree/output/estree.proto
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ilia-kebets-sonarsource ilia-kebets-sonarsource changed the title Remove estree.proto duplication Remove estree.proto file duplication Aug 29, 2024
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilia-kebets-sonarsource ilia-kebets-sonarsource merged commit 1c12ea7 into master Aug 29, 2024
18 of 19 checks passed
@ilia-kebets-sonarsource ilia-kebets-sonarsource deleted the remove-proto-duplicates branch August 29, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants