ESLINTJS-56 Improve the performances of package manifest search #4840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmorand-sonarsource
force-pushed
the
ESLINTJS-56
branch
10 times, most recently
from
c23131b
to
2b8a6fb
Compare
vdiez
requested changes
Sep 23, 2024
ericmorand-sonarsource
force-pushed
the
ESLINTJS-56
branch
from
2b8a6fb
to
795a139
Compare
ericmorand-sonarsource
force-pushed
the
ESLINTJS-56
branch
from
795a139
to
66831ca
Compare
vdiez
requested changes
Sep 23, 2024
|
|
||
| cache.set(from, cacheContent); | ||
|
|
||
| for (const entry of filesystem.readdirSync(from)) { |
There was a problem hiding this comment.
if you are listing and stating, better use filesystem.readdirSync(dir, { withFileTypes: true }); which makes both in the same call
| if (stats.isFile()) { | ||
| const basename = Path.basename(fullEntryPath); | ||
|
|
||
| if (new Minimatch(pattern).match(basename)) { |
There was a problem hiding this comment.
new Minimatch(pattern) will always be the same. I think we could extract from here and pass it in the constructor createFindUp. WDYT?
ericmorand-sonarsource
force-pushed
the
ESLINTJS-56
branch
from
e88ef2b
to
ea50c38
Compare
ericmorand-sonarsource
force-pushed
the
ESLINTJS-56
branch
from
ea50c38
to
a5d38a9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ESLINTJS-56