Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S6959: "Array.reduce()" calls should include an initial value #3818

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource changed the title Create rule S6959 Create rule S6959: "Array.reduce()" calls should include an initial value Mar 26, 2024
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource marked this pull request as ready for review March 26, 2024 10:21
"status": "ready",
"remediation": {
"func": "Constant\/Issue",
"constantCost": "5min"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this could be decreased to 2min

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@zglicz zglicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noidea

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit 18f43c5 into master Mar 27, 2024
10 of 11 checks passed
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource deleted the rule/add-RSPEC-S6959 branch March 27, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants