Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4934: Posture page feature flag #902

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Conversation

maffkipp
Copy link
Contributor

@maffkipp maffkipp commented Oct 11, 2024

Description

Adds a new feature flag to the current migration file with the key updated_posture_page. The flag should initially be set to false and should be non user-updatable.

Motivation and Context

This feature flag will be used for toggling to the new posture page during development.

This PR addresses: BED-4934

How Has This Been Tested?

Confirmed migration runs on startup and creates the new flag with the expected settings and initial value.

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Database Migrations

Checklist:

  • I have met the contributing prerequisites
  • I have ensured that related documentation is up-to-date
    • Open API docs
    • Code comments (GoDocs / JSDocs)
  • I have followed proper test practices
    • Added/updated tests to cover my changes
    • All new and existing tests passed

@maffkipp maffkipp added the api A pull request containing changes affecting the API code. label Oct 11, 2024
@maffkipp maffkipp self-assigned this Oct 11, 2024
@specter-flq
Copy link
Contributor

Makes sense imo, but will defer to the veterans for approval.

Copy link

@byt3exec byt3exec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for DM.sql

@elikmiller
Copy link
Collaborator

Makes sense for DM.sql

@byt3exec perhaps you meant to comment on a different PR?

@maffkipp maffkipp merged commit 075b640 into main Oct 16, 2024
4 checks passed
@maffkipp maffkipp deleted the BED-4934--posture-feature-flag branch October 16, 2024 22:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api A pull request containing changes affecting the API code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants