Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter node property at ingest and for entity panel display #810

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

urangel
Copy link
Contributor

@urangel urangel commented Aug 22, 2024

Description

Prevents 'reconcile' from being persisted in node properties upon ingest.
Prevents 'reconcile' from being displayed in the entity panel if already persisted.

Motivation and Context

This PR addresses: BED-4623

How Has This Been Tested?

Unit tests have been added.

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have met the contributing prerequisites
  • I have ensured that related documentation is up-to-date
    • Open API docs
    • Code comments (GoDocs / JSDocs)
  • I have followed proper test practices
    • Added/updated tests to cover my changes
    • All new and existing tests passed

@urangel urangel added api A pull request containing changes affecting the API code. user interface A pull request containing changes affecting the UI code. labels Aug 22, 2024
@urangel urangel self-assigned this Aug 22, 2024
Copy link
Contributor

@maffkipp maffkipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, appreciate the refactor and all the added tests!

@urangel urangel merged commit ba22f44 into main Sep 10, 2024
4 checks passed
@urangel urangel deleted the BED-4623 branch September 10, 2024 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api A pull request containing changes affecting the API code. user interface A pull request containing changes affecting the UI code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants