Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4871 added SchannelAuthenticationEnabled to cue file properties #883

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

mvlipka
Copy link
Contributor

@mvlipka mvlipka commented Sep 24, 2024

Description

As part of https:/SpecterOps/BloodHound/pull/828/files the SchannelAuthenticationEnabled property was added, but was never added to the properties field in the relevant cue file.

When running just generate it removes this field from the generated go files. This property was likely added in manually and not through generation

Motivation and Context

This PR addresses: BED-4871

This fix allows just generate to work again

How Has This Been Tested?

Run just generate and then I ran any unit tests. Previously I could not run unit tests as the ad package became invalid when running just generate

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have met the contributing prerequisites
  • I have ensured that related documentation is up-to-date
    • Open API docs
    • Code comments (GoDocs / JSDocs)
  • I have followed proper test practices
    • Added/updated tests to cover my changes
    • All new and existing tests passed

@mvlipka mvlipka marked this pull request as ready for review September 24, 2024 15:25
@mvlipka mvlipka added the bug Something isn't working label Sep 24, 2024
@@ -799,6 +799,7 @@ Properties: [
SchemaVersion,
RequiresManagerApproval,
AuthenticationEnabled,
SchannelAuthenticationEnabled,
Copy link
Contributor Author

@mvlipka mvlipka Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the relevant change, the rest is a result of just generate

@mvlipka mvlipka merged commit 08dae9f into main Sep 24, 2024
4 checks passed
@mvlipka mvlipka deleted the BED-4871-fix-SchannelAuthenticationEnabled branch September 24, 2024 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants