Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BED-4753: Added styling selectors to address sections in api explorer not working in dark/light mode #884

Merged
merged 5 commits into from
Sep 25, 2024
Merged

BED-4753: Added styling selectors to address sections in api explorer not working in dark/light mode #884

merged 5 commits into from
Sep 25, 2024

Conversation

specter-flq
Copy link
Contributor

@specter-flq specter-flq commented Sep 24, 2024 •
edited by jira bot
Loading

Description

Added selectors to target elements that were not responding to the dark / light mode functionality in API explorer

Motivation and Context

This addresses ticket BED-4753

How Has This Been Tested?

Tested manually.

Screenshots (optional):

Screenshare.-.2024-09-24.2_54_50.PM.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have met the contributing prerequisites
  • I have ensured that related documentation is up-to-date
    • Open API docs
    • Code comments (GoDocs / JSDocs)
  • I have followed proper test practices
    • Added/updated tests to cover my changes
    • All new and existing tests passed

@specter-flq specter-flq added bug Something isn't working user interface A pull request containing changes affecting the UI code. labels Sep 24, 2024
@specter-flq specter-flq self-assigned this Sep 24, 2024
urangel
urangel approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@urangel urangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for going through all of this. 🙇 It can be difficult to manage these views from external sources but it looks like you were meticulous about finding the styles that need updating!

@specter-flq specter-flq merged commit 7c9308c into stage/v6.0.0 Sep 25, 2024
4 checks passed
@specter-flq specter-flq deleted the BED-4753 branch September 25, 2024 18:23
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@urangel urangel urangel approved these changes

Assignees

@specter-flq specter-flq

Labels
bug Something isn't working user interface A pull request containing changes affecting the UI code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@specter-flq @urangel