Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BED-4869 clean up logging for TenantRoles #885

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

zinic
Copy link
Collaborator

@zinic zinic commented Sep 25, 2024

Description

It would be better to use Measure instead of LogAndMeasure for this call. Measure intentionally does not log unless the measured call exceeds a wall time of 1 second. The intent of this call appears to be identifying potential slow calls so the refactor feels right.

Motivation and Context

Log is too noisy otherwise.

How Has This Been Tested?

Local testing

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Database Migrations

Checklist:

  • I have met the contributing prerequisites
  • I have ensured that related documentation is up-to-date
    • Open API docs
    • Code comments (GoDocs / JSDocs)
  • I have followed proper test practices
    • Added/updated tests to cover my changes
    • All new and existing tests passed

@zinic zinic changed the base branch from main to stage/v6.0.0 September 25, 2024 16:24
@zinic zinic merged commit 399d3e5 into stage/v6.0.0 Sep 25, 2024
4 checks passed
@zinic zinic deleted the BED-4869 branch September 25, 2024 17:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants