Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4947: Fix Last Analysis Run At Bug #907

Merged
merged 2 commits into from
Oct 17, 2024
Merged

BED-4947: Fix Last Analysis Run At Bug #907

merged 2 commits into from
Oct 17, 2024

Conversation

superlinkx
Copy link
Contributor

@superlinkx superlinkx commented Oct 17, 2024

Description

Fixes a logic bug that was causing last_analysis_run_at to run every time the datapipe status changed

Motivation and Context

This PR addresses: BED-4947

Why is this change required? What problem does it solve?

This bug was causing scheduled analysis to never run

How Has This Been Tested?

  • Existing test has been updated to account for the correct, intended behavior

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have met the contributing prerequisites
  • I have ensured that related documentation is up-to-date
    • Open API docs
    • Code comments (GoDocs / JSDocs)
  • I have followed proper test practices
    • Added/updated tests to cover my changes
    • All new and existing tests passed

@superlinkx superlinkx added bug Something isn't working api A pull request containing changes affecting the API code. labels Oct 17, 2024
@superlinkx superlinkx self-assigned this Oct 17, 2024
@superlinkx
Copy link
Contributor Author

Looks like we're not getting statuses correctly for some reason in one of our tests. Needs more testing and validation.

@superlinkx superlinkx merged commit b22b6bb into stage/v6.1.0 Oct 17, 2024
4 checks passed
@superlinkx superlinkx deleted the BED-4947 branch October 17, 2024 17:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api A pull request containing changes affecting the API code. bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants