-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acceptance tests for top-level functions #589
Comments
Do a code review and find the functions without side effects that are part of the functional core. Add acceptance tests for important functions like Alternative: if there is a bunch of top-level functions that belong together, put them inside an object or a class (if they have multiple common parameters) so that we use the convention |
We have lots of top-level functions and it's often unclear
For example with the function
getArtifactNameToConstantMapping()
Regarding issue 2, an issue is that if you have a class
FindKitten
, there is a strong convention that you test it in the classFikkndKittenTest
. And you can jump there with the actionGo To Test
.But there is no such convention for top-level functions AFAIK.
The text was updated successfully, but these errors were encountered: