Types: be more specific about required scalar types #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slamdunk
commented
Mar 15, 2023
| @@ -3,23 +3,6 @@ parameters: | |||
| paths: | |||
| - src | |||
| - tests | |||
| ignoreErrors: | |||
There was a problem hiding this comment.
By letting vendor/bin/phpstan analyse --generate-baseline generating the errors, they are much more specific and so eventual future inconsistencies emerge earlier
There was a problem hiding this comment.
Excellent! I was not aware of this command.
I tested it on another project and you are right, it helps a lot.
Slamdunk
force-pushed
the
non_empty_string
branch
from
ee085a9
to
522d95f
Compare
|
Many thanks for this PR! |
|
Hi, may I ask you to release this, maybe in the |
|
Hi, I didn't pay attention, but this PR is based on 11.2.x and not 11.1.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.