Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): prevent content child from clipping elements #1764

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

dancormier
Copy link
Contributor

STACKS-635


This PR ensures that anything extending (12px or less) from the s-popover--content element will still be visible. The largest impact will be on focused inputs within a popover.

Before

image

After

image

@dancormier dancormier added bug A reproducible problem with the Stacks code accessibility labels Jun 21, 2024
@dancormier dancormier requested a review from a team June 21, 2024 18:38
Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit 9b3a5a7
🔍 Latest deploy log https://app.netlify.com/sites/stacks/deploys/6675c8bc0f96850008715230
😎 Deploy Preview https://deploy-preview-1764--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@giamir giamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the fix. 🙂

@dancormier dancormier merged commit 9bc19f2 into develop Jun 25, 2024
11 checks passed
@dancormier dancormier deleted the STACKS-635/popover-content-clipping-fix branch June 25, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug A reproducible problem with the Stacks code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants