Fix misleading config param github_url/base_url #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mismatch of `github_url` and `base_url` acturally breaks github enterprise support.
everpcpc
force-pushed
the
fix
branch
4 times, most recently
from
d3270a8
to
e1c0474
Compare
|
Sorry this one got missed earlier. In general I agree with cleaning this up. Could do please do this: 1/ Check README.md, see if that needs any updates to reflect this change Then we can merge it |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mismatch of
github_urlandbase_urlacturally breaks github enterprise support for those actions which do not use_request.related issue: #20